linux-kernel - Re: [PATCH] bpf: btf: include linux/types.h for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh93hKfHgsw5wQAw@krava>
Date: Wed, 17 Apr 2024 09:17:24 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Cc: Daniel Borkmann <daniel@...earbox.net>, Jiri Olsa <olsajiri@...il.com>,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
	haoluo@...gle.com, sdf@...gle.com, kpsingh@...nel.org,
	john.fastabend@...il.com, yonghong.song@...ux.dev, song@...nel.org,
	eddyz87@...il.com, andrii@...nel.org, ast@...nel.org,
	martin.lau@...ux.dev, khazhy@...omium.org, vmalik@...hat.com,
	ndesaulniers@...gle.com, ncopa@...inelinux.org, dxu@...uu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32

On Wed, Apr 17, 2024 at 09:26:03AM +0300, Dmitrii Bundin wrote:
> On Tue, Apr 16, 2024 at 5:47 PM Daniel Borkmann <daniel@...earbox.net> wrote:
> > Please add the error description as motivation aka "why" into the commit
> > description, otherwise it's not really obvious looking at it at a later
> > point in time why the include was needed.
> 
> Doesn't the comment /* for u32 */ following the include explain the
> purpose? I thought the include was actually missing since relying on
> indirect declaration of u32 is relatively fragile.

I think you can add similar descirption as for the already merged tool
change in bpf/master, and also include the Fixes/stable tags

commit 62248b22d01e96a4d669cde0d7005bd51ebf9e76
Author: Natanael Copa <ncopa@...inelinux.org>
Date:   Thu Mar 28 11:59:13 2024 +0100

    tools/resolve_btfids: fix build with musl libc
    
    Include the header that defines u32.
    This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
    uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
    
    Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
    Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
    Cc: stable@...r.kernel.org
    Signed-off-by: Natanael Copa <ncopa@...inelinux.org>
    Tested-by: Greg Thelen <gthelen@...gle.com>
    Link: https://lore.kernel.org/r/20240328110103.28734-1-ncopa@alpinelinux.org
    Signed-off-by: Alexei Starovoitov <ast@...nel.org>


jirka