linux-kernel - Re: [PATCH v2 1/1] x86/fred: Fix INT80 emulation for FRED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4873337c-7877-485a-a86d-1ba454792fa7@zytor.com>
Date: Tue, 16 Apr 2024 23:51:10 -0700
From: Xin Li <xin@...or.com>
To: "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, luto@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, dave.hansen@...ux.intel.com, x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/fred: Fix INT80 emulation for FRED

On 4/16/2024 11:33 AM, H. Peter Anvin wrote:
> On 4/16/24 11:28, Borislav Petkov wrote:
>> On Tue, Apr 16, 2024 at 11:23:24AM -0700, H. Peter Anvin wrote:
>>> (I think there is actually less than half the code left. This could be
>>> further cleaned up by inlining the common code,
>>
>> Yeah, was just thinking about that too. I'd say, though, let's let the
>> FRED code settle, we start using it and then we can always unify common
>> stuff later if it turns out that it won't diverge anymore.
> 
> Good plan.

This is a nice tip to me, because I did feel a bit of guilty that I 
didn't use an inline common function, although I didn't think that
is really necessary.

Thanks!
     Xin