linux-kernel - Re: [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Apr 2024 06:06:17 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Li kunyu <kunyu@...china.com>, chuck.lever@...cle.com, neilb@...e.de, 
	kolga@...app.com, Dai.Ngo@...cle.com, tom@...pey.com, 
	trond.myklebust@...merspace.com, anna@...nel.org
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockd: host: Remove unnecessary
 statements＇host = NULL;＇

On Wed, 2024-04-17 at 16:28 +0800, Li kunyu wrote:
> In 'nlm_alloc_host', the host has already been assigned a value of NULL
> when defined, so 'host=NULL;' Can be deleted.
> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> ---
>  fs/lockd/host.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index 127a728fcbc81..c115168017845 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -117,7 +117,6 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni,
>  	if (nsm != NULL)
>  		refcount_inc(&nsm->sm_count);
>  	else {
> -		host = NULL;
>  		nsm = nsm_get_handle(ni->net, ni->sap, ni->salen,
>  					ni->hostname, ni->hostname_len);
>  		if (unlikely(nsm == NULL)) {

Reviewed-by: Jeff Layton <jlayton@...nel.org>