[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240418-skinless-aptitude-245665a7c757@spud>
Date: Thu, 18 Apr 2024 16:57:00 +0100
From: Conor Dooley <conor@...nel.org>
To: Dragan Simic <dsimic@...jaro.org>
Cc: Chukun Pan <amadeus@....edu.cn>, Heiko Stuebner <heiko@...ech.de>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, FUKAUMI Naoki <naoki@...xa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name
for Radxa ROCK 3A
On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
> Hello Conor,
>
> On 2024-04-18 17:37, Conor Dooley wrote:
> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
> > > On 2024-04-18 15:01, Chukun Pan wrote:
> > > > According to https://radxa.com/products/rock3/3a,
> > > > the name of this board should be "Radxa ROCK 3A".
> > > > Also update compatible to match the model name.
> > > >
> > > > Suggested-by: FUKAUMI Naoki <naoki@...xa.com>
> > > > Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> > >
> > > Looking good to me. I'll send the remaining naming cleanup patches
> > > a bit later.
> >
> > What remaining patches?
>
> The same naming cleanups need to be performed for the Radxa
> ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
> boards in mind, but I'll drop them after your NAK. [2]
>
> Though, I'm not really sure why the NAK? Those names aren't
> used anywhere, neither in the Linux kernel, nor in U-Boot.
There may well be other users outside of those two projects that are
actually looking at it - I don't think that adding a hyphen is worth
disrupting anyone for, it seems perfectly clear without it what board
this is.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists