linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <865d70eea51c18570d94a4fc86dcb5b5@manjaro.org>
Date: Thu, 18 Apr 2024 17:58:54 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Conor Dooley <conor@...nel.org>
Cc: Chukun Pan <amadeus@....edu.cn>, Heiko Stuebner <heiko@...ech.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, FUKAUMI Naoki
 <naoki@...xa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name
 for Radxa ROCK 3A

On 2024-04-18 17:57, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
>> On 2024-04-18 17:37, Conor Dooley wrote:
>> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> > > On 2024-04-18 15:01, Chukun Pan wrote:
>> > > > According to https://radxa.com/products/rock3/3a,
>> > > > the name of this board should be "Radxa ROCK 3A".
>> > > > Also update compatible to match the model name.
>> > > >
>> > > > Suggested-by: FUKAUMI Naoki <naoki@...xa.com>
>> > > > Signed-off-by: Chukun Pan <amadeus@....edu.cn>
>> > >
>> > > Looking good to me.  I'll send the remaining naming cleanup patches
>> > > a bit later.
>> >
>> > What remaining patches?
>> 
>> The same naming cleanups need to be performed for the Radxa
>> ROCK 5 boards. [1]  I had some more cleanups for the ROCK 4
>> boards in mind, but I'll drop them after your NAK. [2]
>> 
>> Though, I'm not really sure why the NAK?  Those names aren't
>> used anywhere, neither in the Linux kernel, nor in U-Boot.
> 
> There may well be other users outside of those two projects that are
> actually looking at it - I don't think that adding a hyphen is worth
> disrupting anyone for, it seems perfectly clear without it what board
> this is.

I see, it's perhaps better to stay on the safe side.