linux-kernel - Re: [PATCH 1/2] drm/panel: panel-simple: Add generic panel-dsi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76b46467-6a27-4f07-8a3e-cdd51e2e28bb@linaro.org>
Date: Fri, 19 Apr 2024 01:06:19 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Adolfsson <johan.adolfsson@...s.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>, Sam Ravnborg <sam@...nborg.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH 1/2] drm/panel: panel-simple: Add generic panel-dsi driver

On 18/04/2024 16:01, Johan Adolfsson wrote:
> Add generic panel-dsi panel, similar to panel-dpi that can have it's
> timing, lanes and flags overridden by devicetree.
> Add some dev_err() and dev_warn() calls.
> 

..

>  		/* sentinel */
>  	}
> @@ -4992,17 +5051,28 @@ static int panel_simple_dsi_probe(struct mipi_dsi_device *dsi)
>  		return -ENODEV;
>  
>  	err = panel_simple_probe(&dsi->dev, &desc->desc);
> +	if (err)
> +		dev_err(&dsi->dev, "%s: err %i\n", __func__, err);

This looks like debugging code.

> +
> +	if (desc == &panel_dsi) {
> +		struct panel_simple *panel = mipi_dsi_get_drvdata(dsi);
> +		/* Handle the generic panel-dsi binding */
> +		err = panel_dsi_probe(&dsi->dev, panel);
> +	}
> +
>  	if (err < 0)
>  		return err;
>  
>  	dsi->mode_flags = desc->flags;
>  	dsi->format = desc->format;
>  	dsi->lanes = desc->lanes;
> +	of_property_read_u32(dsi->dev.of_node, "lanes", &dsi->lanes);

Is this defined in the binding?

>  
>  	err = mipi_dsi_attach(dsi);
>  	if (err) {
>  		struct panel_simple *panel = mipi_dsi_get_drvdata(dsi);
>  
> +		dev_err(&dsi->dev, "probe attach err: %i", err);

Do not introduce unrelated code changes.

Best regards,
Krzysztof