linux-kernel - Re: [PATCH v4 6/7] serial: exar: add CTI specific setup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024041810-regain-handgrip-a942@gregkh>
Date: Thu, 18 Apr 2024 07:42:34 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Parker Newman <parker@...est.io>
Cc: kernel test robot <lkp@...el.com>, Jiri Slaby <jirislaby@...nel.org>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	oe-kbuild-all@...ts.linux.dev,
	Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH v4 6/7] serial: exar: add CTI specific setup code

On Thu, Apr 18, 2024 at 01:29:14PM +0800, kernel test robot wrote:
> Hi Parker,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on b86ae40ffcf5a16b9569b1016da4a08c4f352ca2]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Parker-Newman/serial-exar-remove-old-Connect-Tech-setup/20240418-043457
> base:   b86ae40ffcf5a16b9569b1016da4a08c4f352ca2
> patch link:    https://lore.kernel.org/r/ae4a66e7342b686cb8d4b15317585dfb37222cf4.1713382717.git.pnewman%40connecttech.com
> patch subject: [PATCH v4 6/7] serial: exar: add CTI specific setup code
> config: alpha-defconfig (https://download.01.org/0day-ci/archive/20240418/202404181353.1VIC4cz9-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404181353.1VIC4cz9-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404181353.1VIC4cz9-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/tty/serial/8250/8250_exar.c:727: warning: Function parameter or struct member 'pcidev' not described in 'cti_get_port_type_xr17c15x_xr17v25x'
> >> drivers/tty/serial/8250/8250_exar.c:819: warning: Function parameter or struct member 'pcidev' not described in 'cti_get_port_type_fpga'
> >> drivers/tty/serial/8250/8250_exar.c:849: warning: Function parameter or struct member 'pcidev' not described in 'cti_get_port_type_xr17v35x'
> 
> 
> vim +727 drivers/tty/serial/8250/8250_exar.c
> 
>    714	
>    715	/**
>    716	 * cti_get_port_type_xr17c15x_xr17v25x() - Get port type of xr17c15x/xr17v25x
>    717	 * @priv: Device's private structure
>    718	 * @port_num: Port to get type of
>    719	 *
>    720	 * CTI xr17c15x and xr17v25x based cards port types are based on PCI IDs.
>    721	 *
>    722	 * Return: port type on success, CTI_PORT_TYPE_NONE on failure
>    723	 */
>    724	static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *priv,
>    725								struct pci_dev *pcidev,
>    726								unsigned int port_num)
>  > 727	{

Parker, no need to resend this, you can send a follow-on patch after
this to resolve it.  Simplest way is to just not do kernel-doc formats
for static functions, as it's usually not needed.  Or you can add the
function parameter, either one will silence the warning.

thanks,

greg k-h