linux-kernel - Re: [PATCH v4 0/7] serial: exar: add Connect Tech serial cards to Exar driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Apr 2024 08:25:10 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Parker Newman <parker@...est.io>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH v4 0/7] serial: exar: add Connect Tech serial cards to
 Exar driver

On Wed, Apr 17, 2024 at 04:31:22PM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@...necttech.com>
> 
> Hello,
> These patches add proper support for most of Connect Tech's (CTI) Exar
> based serial cards. Previously, only a subset of CTI's cards would work
> with the Exar driver while the rest required the CTI out-of-tree driver.
> These patches are intended to phase out the out-of-tree driver.
> 
> I am new to the mailing lists and contributing to the kernel so please
> let me know if I have made any mistakes or if you have any feedback.
> 
> Changes in v2:
> - Put missing PCI IDs in 8250_exar.c instead of pci_ids.h
> - Split large patch into smaller ones
> 
> Changes in v3:
> - Refactored patches to be easier to follow (based on feedback of v2)
> - Patch specific changes listed in corresponding patch
> 
> Changes in v4:
> - Rebased to tty-testing branch
> - Removed v3 patch 8/8, "bug" didn't happen in current driver
> - Patch specific changes listed in corresponding patch
> 
> Thank you,
> 
> Parker Newman (7):
>   serial: exar: remove old Connect Tech setup
>   serial: exar: added a exar_get_nr_ports function
>   serial: exar: add optional board_init function
>   serial: exar: moved generic_rs485 further up in 8250_exar.c
>   serial: exar: add CTI cards to exar_get_nr_ports
>   serial: exar: add CTI specific setup code
>   serial: exar: fix checkpach warnings
> 
>  drivers/tty/serial/8250/8250_exar.c | 981 ++++++++++++++++++++++++++--
>  1 file changed, 916 insertions(+), 65 deletions(-)

Nice, compared to your first version, this is less code overall in this
file:
   1 file changed, 1019 insertions(+), 70 deletions(-)

so the review process helped!

All now applied to my tree, thanks for the revisions.  And a follow-on
patch to fix up the kbuild warning would be appreciated.

thanks,

greg k-h