linux-kernel - Re: [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5c946d2-6271-8619-72ca-15860555218d@huawei.com>
Date: Thu, 18 Apr 2024 10:11:08 +0800
From: xiujianfeng <xiujianfeng@...wei.com>
To: Tejun Heo <tj@...nel.org>, Xiu Jianfeng <xiujianfeng@...weicloud.com>
CC: <lizefan.x@...edance.com>, <hannes@...xchg.org>,
	<cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all()
 for v2

Hi,

On 2024/4/18 10:02, Tejun Heo wrote:
> Hello,
> 
> On Wed, Apr 17, 2024 at 02:13:59AM +0000, Xiu Jianfeng wrote:
>> From: Xiu Jianfeng <xiujianfeng@...wei.com>
>>
>> Currently cgroup1_pidlist_destroy_all() will be called when releasing
>> cgroup even if the cgroup is on default hierarchy, however it doesn't
>> make any sense for v2 to destroy pidlist of v1.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
>> ---
>>  kernel/cgroup/cgroup-v1.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
>> index 520a11cb12f4..46d89157d558 100644
>> --- a/kernel/cgroup/cgroup-v1.c
>> +++ b/kernel/cgroup/cgroup-v1.c
>> @@ -197,6 +197,8 @@ void cgroup1_pidlist_destroy_all(struct cgroup *cgrp)
>>  {
>>  	struct cgroup_pidlist *l, *tmp_l;
>>  
>> +	if (cgroup_on_dfl(cgrp))
>> +		return;
> 
> Can you move the test to the caller?

Sure, will do in v2.

> 
> Thanks.
>