linux-kernel - Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 21:47:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Aleksandr Mishin <amishin@...rgos.ru>, dri-devel@...ts.freedesktop.org,
 lvc-project@...uxtesting.org, kernel-janitors@...r.kernel.org,
 Robert Foss <rfoss@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Aradhya Bhatia <a-bhatia1@...com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Jani Nikula <jani.nikula@...el.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jonas Karlman <jonas@...boo.se>,
 Jyri Sarha <jsarha@...com>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Nikhil Devshatwar <nikhil.nd@...com>,
 Quentin Schulz <quentin.schulz@...e-electrons.com>,
 Rob Herring <robh@...nel.org>, Swapnil Jakhade <sjakhade@...ence.com>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Tomi Valkeinen <tomi.valkeinen@...com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Yuti Amonkar <yamonkar@...ence.com>, Zhu Wang <wangzhu9@...wei.com>
Subject: Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on
 error path

…
> Add a mutex unlock call.

How do you think about a wording variant like the following?

   Extend the exception handling so that the missed mutex_unlock() call
   will be performed finally.


Regards,
Markus