linux-kernel - Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 18:02:23 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Robert Foss <rfoss@...nel.org>, Swapnil Jakhade <sjakhade@...ence.com>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	Tomi Valkeinen <tomi.valkeinen@...com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Nikhil Devshatwar <nikhil.nd@...com>, 
	Aradhya Bhatia <a-bhatia1@...com>, Jani Nikula <jani.nikula@...el.com>, 
	Rob Herring <robh@...nel.org>, Zhu Wang <wangzhu9@...wei.com>, 
	Yuti Amonkar <yamonkar@...ence.com>, Jyri Sarha <jsarha@...com>, 
	Quentin Schulz <quentin.schulz@...e-electrons.com>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on
 error path

On Fri, Apr 19, 2024 at 02:36:37PM +0300, Aleksandr Mishin wrote:
> In cdns_mhdp_atomic_enable(), there is an error return on failure of
> drm_mode_duplicate() which leads to the mutex remaining locked.
> Add a mutex unlock call.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
> This patch is against drm-misc-next branch of drm-misc repo.
> 
>  drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> 


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


-- 
With best wishes
Dmitry