linux-kernel - Re: [PATCH v5 0/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFA6WYMtnAjkK0j-KqrUNWOTSnxjvrayBk3+4gqUE+ZxgceieQ@mail.gmail.com>
Date: Fri, 19 Apr 2024 09:12:44 -0700
From: Sumit Garg <sumit.garg@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, stephan@...hold.net, 
	caleb.connolly@...aro.org, neil.armstrong@...aro.org, 
	laetitia.mariottini@...com, pascal.eberhard@...com, abdou.saker@...com, 
	jimmy.lalande@...com, benjamin.missey@....se.com, daniel.thompson@...aro.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC
 board DTS

On Fri, 19 Apr 2024 at 08:31, Dmitry Baryshkov
<dmitry.baryshkov@...aro.org> wrote:
>
> On Fri, 19 Apr 2024 at 18:27, Sumit Garg <sumit.garg@...aro.org> wrote:
> >
> > On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@...aro.org> wrote:
> > >
> > > Hi Bjorn, Konrad,
> > >
> > > On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@...aro.org> wrote:
> > > >
> > > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge
> > > > Box Core board based on the Qualcomm APQ8016E SoC. For more information
> > > > refer to the product page [1].
> > > >
> > > > One of the major difference from db410c is serial port where HMIBSC board
> > > > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux
> > > > configured via gpio99 and gpio100).
> > > >
> > > > Support for Schneider Electric HMIBSC. Features:
> > > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306)
> > > > - 1GiB RAM
> > > > - 8GiB eMMC, SD slot
> > > > - WiFi and Bluetooth
> > > > - 2x Host, 1x Device USB port
> > > > - HDMI
> > > > - Discrete TPM2 chip over SPI
> > > > - USB ethernet adaptors (soldered)
> > > >
> > > > This series is a v2 since v1 of this DTS file has been reviewed on the
> > > > U-Boot mailing list [2].
> > > >
> > > > Changes in v5:
> > > > - Addressed another nitpick from Stephen.
> > > > - Collected Stephen's review tag.
> > > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC
> > > >   board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt
> > > >   still not converted to YAML format.
> > > >
> > >
> > > I haven't seen any further comments on this series, can you help to pick it up?
> >
> > Gentle reminder.
>
> I see an email from Rob. At least GPIO-related warnings are related to HMIBSC
>

I suppose you are referring to:

arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: pmic@0:
gpio@...0:gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM',
'NC', 'NC'] is too short
from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: gpio@...0:
gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM', 'NC', 'NC']
is too short
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml#

I am really not sure as to why those warnings are being reported for
v5 and not reported for v4 here [1]. Also, there are only 4 PMIC GPIOs
available on PM8916 out of which only 2 are connected on HMIBSC and
the other 2 are not connected. AFAICT, these seem to be false warning
reports or am I missing something?

[1] https://lore.kernel.org/lkml/171155390164.3454213.14779164019451021567.robh@kernel.org/

-Sumit

>
> --
> With best wishes
> Dmitry