linux-kernel - Re: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 20 Apr 2024 11:55:15 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Alisa-Dariana Roman <alisadariana@...il.com>,
 michael.hennerich@...log.com, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 alexandru.tachici@...log.com, lars@...afoo.de, robh@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org,
 nuno.sa@...log.com, marcelo.schmitt@...log.com, bigunclemax@...il.com,
 dlechner@...libre.com, okan.sahin@...log.com, fr0st61te@...il.com,
 alisa.roman@...log.com, marcus.folkesson@...il.com, schnelle@...ux.ibm.com,
 liambeguin@...il.com
Subject: Re: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support

On Wed, 17 Apr 2024 20:06:00 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Wed, Apr 17, 2024 at 8:01 PM Alisa-Dariana Roman
> <alisadariana@...il.com> wrote:
> >
> > Unlike the other AD719Xs, AD7194 has configurable differential
> > channels. The user can dynamically configure them in the devicetree.
> >
> > Also modify config AD7192 description for better scaling.  
> 
> ...
> 
> > +       device_for_each_child_node(dev, child) {  
> 
> You can use scoped variant AFAIU that's available in Jonathan's tree.
> 
> > +               *ad7194_channels = ad7194_chan_diff;
> > +               ad7194_channels->scan_index = index++;
> > +               ret = ad7194_parse_channel(child, ad7194_channels);
> > +               if (ret) {  
> 
> > +                       fwnode_handle_put(child);  
> 
> With the above this wouldn't be needed.
> 
As it's a minor improvement, and I tend not to like unnecessary
interdependence of series in my tree (until they are in char-misc
and hence no chance of them changing), I'm fine with not using
that new functionality here. 

That will change once it's upstream of course!

I will send a pull request to Greg nice and early this cycle
so that should be in my upstream soon.

I'm also fine with you using this if you want to though!

Jonathan

> > +                       return ret;
> > +               }
> > +               ad7194_channels++;
> > +       }  
>