linux-kernel - Re: [PATCH v2 1/4] dt-bindings: power: reset: Convert mode-.* properties to array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19bee3e2-ea14-4fe9-ba10-497166ab791e@linaro.org>
Date: Sat, 20 Apr 2024 02:50:26 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elliot Berman <quic_eberman@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Sebastian Reichel
 <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Andy Yan <andy.yan@...k-chips.com>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Cc: Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>,
 Melody Olvera <quic_molvera@...cinc.com>,
 Shivendra Pratap <quic_spratap@...cinc.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Florian Fainelli <florian.fainelli@...adcom.com>, linux-pm@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: power: reset: Convert mode-.*
 properties to array

On 14/04/2024 21:30, Elliot Berman wrote:
> PSCI reboot mode will map a mode name to multiple magic values instead
> of just one. Convert the mode-.* property to an array. Users of the
> reboot-mode schema will need to specify the maxItems of the mode-.*
> properties. Existing users will all be 1.
> 
> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
> ---
>  .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml   |  4 ++++
>  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml  |  4 ++++
>  .../devicetree/bindings/power/reset/reboot-mode.yaml         | 12 ++++++++++--
>  .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml  |  4 ++++
>  4 files changed, 22 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> index 627f8a6078c2..03b3b9be36de 100644
> --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> @@ -30,6 +30,10 @@ properties:
>  
>  allOf:
>    - $ref: reboot-mode.yaml#
> +  - patternProperties:
> +      "^mode-.*$":
> +        items:
> +          maxItems: 1

You still need to limit total number of items. This only defines how
many items you have in each inner cell of the matrix. What about the
other cell?

I understood that you want something more or less equivalent, but the
code does not look like.



Best regards,
Krzysztof