linux-kernel - Re: [PATCH v21 5/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 20 Apr 2024 19:23:35 +0530
From: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>
CC: <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Rob Herring
	<robh@...nel.org>, Wesley Cheng <quic_wcheng@...cinc.com>,
        <quic_ppratap@...cinc.com>, <quic_jackp@...cinc.com>,
        Bjorn Andersson
	<quic_bjorande@...cinc.com>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Johan Hovold
	<johan@...nel.org>, Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH v21 5/9] dt-bindings: usb: qcom,dwc3: Add bindings for
 SC8280 Multiport



On 4/20/2024 5:01 PM, Krzysztof Kozlowski wrote:
> On 20/04/2024 06:48, Krishna Kurapati wrote:
>> Add the compatible string for SC8280 Multiport USB controller from
>> Qualcomm.
>>
>> There are 4 power event interrupts supported by this controller
>> (one for each port of multiport controller). Add all the 4 as
>> non-optional interrupts for SC8280XP-MP
>>
>> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
>> IRQs related to 4 ports of SC8280XP Teritiary controller.
>>
>> Also added SuperSpeed PHY interrupt for both Superspeed ports.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
>> Reviewed-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> 
> v21 and suddenly you drop tags requiring everyone to re-review this. I
> do not think this process is working. I will not re-review this.
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 

Hi Krzysztof,

  There was a commit text change to fix minor nits:
  -> One minor spell check: /s/oen/one
  -> minor nits like: /s/ss/SuperSpeed

  So removed the tags and requested for a review.
  "Updated commit text in patches 2/5/6."

  Apologies, My intention was to just fix the spell check and minor nits.
.
  The changes in v21 were in patches 1/2/4/7/9.
  Patches 3 and 8 were left untouched.
  Made minor nit fixes to commit text in patches 5 and 6 so that it 
feels more accurate.

Regards,
Krishna,