linux-kernel - Re: [PATCH v4 2/3] vmlinux: Avoid weak reference to notes section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASq6ieck5Gw1sLZVp9mC3g-HhZWEhHQmG+wDB__4mX8QA@mail.gmail.com>
Date: Sat, 20 Apr 2024 22:42:32 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Ard Biesheuvel <ardb+git@...gle.com>
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>, Martin KaFai Lau <martin.lau@...ux.dev>, linux-arch@...r.kernel.org, 
	linux-kbuild@...r.kernel.org, bpf@...r.kernel.org, 
	Andrii Nakryiko <andrii@...nel.org>, Jiri Olsa <olsajiri@...il.com>
Subject: Re: [PATCH v4 2/3] vmlinux: Avoid weak reference to notes section

On Tue, Apr 16, 2024 at 1:20 AM Ard Biesheuvel <ardb+git@...gle.com> wrote:
>
> From: Ard Biesheuvel <ardb@...nel.org>
>
> Weak references are references that are permitted to remain unsatisfied
> in the final link. This means they cannot be implemented using place
> relative relocations, resulting in GOT entries when using position
> independent code generation.
>
> The notes section should always exist, so the weak annotations can be
> omitted.
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>


Applied to linux-kbuild.
Thanks.




> ---
>  kernel/ksysfs.c | 4 ++--
>  lib/buildid.c   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
> index 495b69a71a5d..07fb5987b42b 100644
> --- a/kernel/ksysfs.c
> +++ b/kernel/ksysfs.c
> @@ -228,8 +228,8 @@ KERNEL_ATTR_RW(rcu_normal);
>  /*
>   * Make /sys/kernel/notes give the raw contents of our kernel .notes section.
>   */
> -extern const void __start_notes __weak;
> -extern const void __stop_notes __weak;
> +extern const void __start_notes;
> +extern const void __stop_notes;
>  #define        notes_size (&__stop_notes - &__start_notes)
>
>  static ssize_t notes_read(struct file *filp, struct kobject *kobj,
> diff --git a/lib/buildid.c b/lib/buildid.c
> index 898301b49eb6..7954dd92e36c 100644
> --- a/lib/buildid.c
> +++ b/lib/buildid.c
> @@ -182,8 +182,8 @@ unsigned char vmlinux_build_id[BUILD_ID_SIZE_MAX] __ro_after_init;
>   */
>  void __init init_vmlinux_build_id(void)
>  {
> -       extern const void __start_notes __weak;
> -       extern const void __stop_notes __weak;
> +       extern const void __start_notes;
> +       extern const void __stop_notes;
>         unsigned int size = &__stop_notes - &__start_notes;
>
>         build_id_parse_buf(&__start_notes, vmlinux_build_id, size);
> --
> 2.44.0.683.g7961c838ac-goog
>
>


-- 
Best Regards
Masahiro Yamada