linux-kernel - Re: [PATCH net,v3] net: ppp: Fix deadlock caused by unsafe-irq lock in ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 17:31:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jeongjun Park <aha310510@...il.com>
Cc: syzbot+393d0ef63475d9bb1f16@...kaller.appspotmail.com,
 davem@...emloft.net, edumazet@...gle.com, linux-kernel@...r.kernel.org,
 linux-ppp@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com,
 gregkh@...uxfoundation.org, jirislaby@...nel.org,
 syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH net,v3] net: ppp: Fix deadlock caused by unsafe-irq lock
 in ap_get()

On Sat, 20 Apr 2024 03:38:15 +0900 Jeongjun Park wrote:
> read_lock() present in ap_get() is interrupt-vulnerable, so the function needs to be modified.
> 
> 
> Reported-by: syzbot+393d0ef63475d9bb1f16@...kaller.appspotmail.com

Improve the commit message to explain the problem more clearly.
Drop the meaningless "so the function needs to be modified."
Remove the double empty line.
Wrap the description at 72 characters.
Read this:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
do not repost in 24h
do not repost in-reply-to other threads

Thanks!
-- 
pw-bot: cr