linux-kernel - Re: [PATCH] sparc: Use swap() to fix Coccinelle warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9dbc4ac-7724-4565-a1d1-ddf19a6488f8@gaisler.com>
Date: Mon, 22 Apr 2024 16:43:32 +0200
From: Andreas Larsson <andreas@...sler.com>
To: Thorsten Blum <thorsten.blum@...lux.com>,
 "David S. Miller" <davem@...emloft.net>
Cc: Rob Herring <robh@...nel.org>, Sam Ravnborg <sam@...nborg.org>,
 sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc: Use swap() to fix Coccinelle warning

On 2024-04-04 13:23, Thorsten Blum wrote:
> Fixes the following Coccinelle/coccicheck warning reported by
> swap.cocci:
> 
> 	WARNING opportunity for swap()
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  arch/sparc/include/asm/floppy_64.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/sparc/include/asm/floppy_64.h b/arch/sparc/include/asm/floppy_64.h
> index 6efeb24b0a92..83decacd0a2d 100644
> --- a/arch/sparc/include/asm/floppy_64.h
> +++ b/arch/sparc/include/asm/floppy_64.h
> @@ -704,9 +704,7 @@ static unsigned long __init sun_floppy_init(void)
>  			ns87303_modify(config, ASC, ASC_DRV2_SEL, 0);
>  			ns87303_modify(config, FCR, 0, FCR_LDE);
>  
> -			config = sun_floppy_types[0];
> -			sun_floppy_types[0] = sun_floppy_types[1];
> -			sun_floppy_types[1] = config;
> +			swap(sun_floppy_types[0], sun_floppy_types[1]);
>  
>  			if (sun_pci_broken_drive != -1) {
>  				sun_pci_broken_drive = 1 - sun_pci_broken_drive;

Reviewed-by: Andreas Larsson <andreas@...sler.com>

Picking this up to my for-next

Thanks,
Andreas