linux-kernel - Re: [PATCH] sparc: Compare pointers to NULL instead of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be681d47-81d4-470a-bdf2-d147d0cd4789@gaisler.com>
Date: Mon, 22 Apr 2024 16:43:56 +0200
From: Andreas Larsson <andreas@...sler.com>
To: Thorsten Blum <thorsten.blum@...lux.com>,
 "David S. Miller" <davem@...emloft.net>
Cc: sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc: Compare pointers to NULL instead of 0

On 2024-04-04 21:29, Thorsten Blum wrote:
> Fixes the following two Coccinelle/coccicheck warnings reported by
> badzero.cocci:
> 
> 	WARNING comparing pointer to 0
> 	WARNING comparing pointer to 0
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  arch/sparc/prom/tree_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/prom/tree_64.c b/arch/sparc/prom/tree_64.c
> index 989e7992d629..88793e5b0ab5 100644
> --- a/arch/sparc/prom/tree_64.c
> +++ b/arch/sparc/prom/tree_64.c
> @@ -332,7 +332,7 @@ prom_setprop(phandle node, const char *pname, char *value, int size)
>  
>  	if (size == 0)
>  		return 0;
> -	if ((pname == 0) || (value == 0))
> +	if ((pname == NULL) || (value == NULL))
>  		return 0;
>  	
>  #ifdef CONFIG_SUN_LDOMS

Reviewed-by: Andreas Larsson <andreas@...sler.com>

Picking this up to my for-next

Thanks,
Andreas