lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240422-repackage-popper-8a062acf2610@spud>
Date: Mon, 22 Apr 2024 16:28:00 +0100
From: Conor Dooley <conor@...nel.org>
To: Konstantin Pugin <ria.freelander@...il.com>
Cc: krzk@...nel.org, lkp@...el.com, vz@...ia.com, robh@...nel.org,
	jcmvbkbc@...il.com, nicolas.ferre@...rochip.com,
	manikanta.guntupalli@....com, corbet@....net, ychuang3@...oton.com,
	u.kleine-koenig@...gutronix.de, Maarten.Brock@...ls.nl,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>,
	Andy Shevchenko <andy@...nel.org>,
	Lech Perczak <lech.perczak@...lingroup.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for
 XR20M1172 UART

On Mon, Apr 22, 2024 at 04:32:14PM +0300, Konstantin Pugin wrote:
> Add EXAR XR20M1172 UART compatible line into devicetree documentation.

I thought I had already pointed out a need for the commit message to
explain why this exar device belongs in this file. IIRC you said it was
in the driver commit and cover letter, but it needs to go here too.

Thanks,
Conor.

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>
> Signed-off-by: Konstantin Pugin <ria.freelander@...il.com>
> ---
>  Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> index 5dec15b7e7c3..c4bedf23368b 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> @@ -12,6 +12,7 @@ maintainers:
>  properties:
>    compatible:
>      enum:
> +      - exar,xr20m1172
>        - nxp,sc16is740
>        - nxp,sc16is741
>        - nxp,sc16is750
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ