linux-kernel - Re: [PATCH v7 0/3] add support for EXAR XR20M1172 UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 15:51:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Konstantin P." <ria.freelander@...il.com>
Cc: conor@...nel.org, lkp@...el.com, vz@...ia.com, robh@...nel.org,
 jcmvbkbc@...il.com, nicolas.ferre@...rochip.com,
 manikanta.guntupalli@....com, corbet@....net, ychuang3@...oton.com,
 u.kleine-koenig@...gutronix.de, Maarten.Brock@...ls.nl,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Hugo Villeneuve
 <hvilleneuve@...onoff.com>, Andy Shevchenko <andy@...nel.org>,
 Lech Perczak <lech.perczak@...lingroup.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v7 0/3] add support for EXAR XR20M1172 UART

On 22/04/2024 15:50, Konstantin P. wrote:
> On Mon, Apr 22, 2024 at 4:45 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 22/04/2024 15:32, Konstantin Pugin wrote:
>>> EXAR XR20M1172 UART is mostly SC16IS762-compatible, but
>>> it has additional register which can change UART multiplier
>>> to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this
>>> flag to guard access to its specific DLD register. It seems than
>>> other EXAR SPI UART modules also have this register, but I tested
>>> only XR20M1172.
>>> Yes, in datasheet this register is called "DLD - Divisor Fractional"
>>> or "DLD - Divisor Fractional Register", calling depends on datasheet
>>> version.
>>>
>>> I am sorry about too many submissions and top post reply. About second -
>>> I do not know how to reply properly to this ML from GMail phone app. About first - I just
>>> get very good feedback from Andy Shevchenko, and want to fix his review picks ASAP.
>>>
>>
>> One patchset per 24h.
>>
>> Plus, you already got such review comment:
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions, under or above your Signed-off-by tag. Tag is "received", when
>> provided in a message replied to you on the mailing list. Tools like b4
>> can help here. However, there's no need to repost patches *only* to add
>> the tags. The upstream maintainer will do that for tags received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
>> Just start using b4.
> 
> There is not only for tag. I submit fixes for version 4 by mistake,
> so, repost to 7 was necessary, because v6 was not work (as v4). But v7
> should be based on v5, and v5 is tested better around tty-next.

???

You got tag, didn't you? Then explain why you decided to skip it. In the
changelog of patchset which ignores/skips the tag.

Best regards,
Krzysztof