linux-kernel - [PATCH] Replace of_node_put() with new cleanup feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 14:40:06 -0700
From: Xiaxi Shen <shenxiaxi26@...il.com>
To: tglx@...utronix.de,
	mingo@...hat.com,
	bp@...en8.de
Cc: hpa@...or.com,
	shenxiaxi26@...il.com,
	linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org,
	javier.carrasco.cruz@...il.com,
	julia.lawall@...ia.fr
Subject: [PATCH] Replace of_node_put() with new cleanup feature

Use the new cleanup magic to replace of_node_put() with
__free(device_node) marking to auto release and to simplify the error
paths

Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
Signed-off-by: Xiaxi Shen <shenxiaxi26@...il.com>
---
 arch/x86/platform/olpc/olpc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/platform/olpc/olpc.c b/arch/x86/platform/olpc/olpc.c
index 1d4a00e767ec..66c4d1f888e7 100644
--- a/arch/x86/platform/olpc/olpc.c
+++ b/arch/x86/platform/olpc/olpc.c
@@ -202,7 +202,7 @@ static u32 __init get_board_revision(struct device_node *root)
 
 static bool __init platform_detect(void)
 {
-	struct device_node *root = of_find_node_by_path("/");
+	struct device_node *root __free(device_node) = of_find_node_by_path("/");
 	bool success;
 
 	if (!root)
@@ -218,7 +218,6 @@ static bool __init platform_detect(void)
 			olpc_platform_info.boardrev >> 4);
 	}
 
-	of_node_put(root);
 	return success;
 }
 
-- 
2.34.1