linux-kernel - Re: [PATCH] char: tpm: Keep TPM_INF_IO_PORT define for HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 00:33:27 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Niklas Schnelle" <schnelle@...ux.ibm.com>, "Peter Huewe"
 <peterhuewe@....de>
Cc: <linux-integrity@...r.kernel.org>, "Heiko Carstens" <hca@...ux.ibm.com>,
 <linux-kernel@...r.kernel.org>, "Arnd Bergmann" <arnd@...nel.org>
Subject: Re: [PATCH] char: tpm: Keep TPM_INF_IO_PORT define for HAS_IOPORT=n

On Mon Apr 22, 2024 at 3:37 PM EEST, Niklas Schnelle wrote:
> The recent change to handle HAS_IOPORT removed the TPM_INF_IO_PORT
> define for the HAS_IOPORT=n case despite the define being used in
> sections of code not covered by the same ifdef check. This was missed
> because at the moment TCG_INFINEON indirectly depends on HAS_IOPORT via
> PNP which depends on ACPI || ISA. As TCG_INFINEON does in principle
> support MMIO only use add it for COMPILE_TEST to cover the HAS_IOPORT=n
> case.
>
> Link: https://lore.kernel.org/lkml/9d9fa267-067e-421b-9a39-aa178b913298@app.fastmail.com/
> Fixes: dab56f80e7f9 ("char: tpm: handle HAS_IOPORT dependencies")
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>


Thanks!

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

I applied it to my master but for some reason it is not yet reflected
to web ui:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/

But it is still applied and perhaps also visible when you seee this!

BR, Jarkko