linux-kernel - Re: [PATCH v3] eeprom: at24: fix memory corruption race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac9cae80-cd9d-4ae0-9f27-b4b424304cbb@web.de>
Date: Tue, 23 Apr 2024 08:15:33 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Daniel Okazaki <dtokazaki@...gle.com>, kernel-team@...roid.com,
 linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Arnd Bergmann <arnd@...db.de>, Bartosz Golaszewski <brgl@...ev.pl>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] eeprom: at24: fix memory corruption race condition

How do you think about to increase the version number for your attempt in the patch subject?

See also previous contribution:
https://lore.kernel.org/lkml/20240419191200.219548-1-dtokazaki@google.com/
https://lkml.org/lkml/2024/4/19/946

> If the eeprom is not accessible, an nvmem device will be registered, the
> read will fail, and the device will be torn down.
…

Please present the introduction for failure conditions as an enumeration.

> Move the failure point before registering the nvmem device.
…

I would interpret the diff data more in the way that a devm_nvmem_register() call
should be performed a bit later in the implementation of the function “at24_probe”.
How do you think about to mention the affected function also in the summary phrase?

> Changed sha length to 12 in description

A specification was adjusted for a tag.
Please add a version identifier here.
Will version descriptions be extended another bit?

> ---

I suggest to use blank line instead of a duplicate marker line.

Regards,
Markus