linux-kernel - Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0395c3a1-1211-4962-bafd-fbf20be98ce4@gmail.com>
Date: Tue, 23 Apr 2024 08:24:52 +0200
From: Rafał Miłecki <zajec5@...il.com>
To: arinc.unal@...nc9.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>,
 Hauke Mehrtens <hauke@...ke-m.de>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: Tom Brautaset <tbrautaset@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add
 device trees

Hi,

On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
> This patch series documents the compatible strings for ASUS RT-AC3200 and
> ASUS RT-AC5300, and adds the device trees for them.

I was on holidays and couldn't reply earlier.

This patchset looks good to me, thanks for your work!

Bot warnings come from .dtsi so they are not directly caused by your changes.

Nitpicking:
Try to put "reg" before "device_type" in future.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112


> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
> Changes in v2:
> - Patch 3
>    - Remove the chosen node as earlycon is not for mainline use, and the
>      stdout-path property which should be used instead of bootargs =
>      "console=" is already described in bcm4708.dtsi with the same value.
>    - Remove MAC address assignment to switch ports. To explain why shortly,
>      on the switch with CPU port architecture, the LLC Entity associated
>      with each port can be accessed without a distinct MAC address assigned
>      to each port. Therefore, it is unnecessary.
> - Patch 4
>    - Same as above.
> - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com
> 
> ---
> Arınç ÜNAL (4):
>        dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200
>        dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300
>        ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200
>        ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300
> 
>   .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml  |   2 +
>   arch/arm/boot/dts/broadcom/Makefile                |   2 +
>   .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts   | 150 ++++++++++++++++++++
>   .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts  | 156 +++++++++++++++++++++
>   4 files changed, 310 insertions(+)
> ---
> base-commit: 011d79ef1cfad701c2d8e7e80d8c77523af9c771
> change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b
> 
> Best regards,