linux-kernel - Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c59348dc-2f14-4d09-9ab9-36d1c25408f4@arinc9.com>
Date: Tue, 23 Apr 2024 10:03:38 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Rafał Miłecki <zajec5@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>,
 Hauke Mehrtens <hauke@...ke-m.de>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: Tom Brautaset <tbrautaset@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add
 device trees

On 23/04/2024 09:24, Rafał Miłecki wrote:
> Hi,
> 
> On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
>> This patch series documents the compatible strings for ASUS RT-AC3200 and
>> ASUS RT-AC5300, and adds the device trees for them.
> 
> I was on holidays and couldn't reply earlier.
> 
> This patchset looks good to me, thanks for your work!
> 
> Bot warnings come from .dtsi so they are not directly caused by your changes.
> 
> Nitpicking:
> Try to put "reg" before "device_type" in future.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112

I'll address this in v3, thank you.

Arınç