linux-kernel - Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a43b05c-ca2e-4fa6-b1f9-cb1a12778da7@kernel.org>
Date: Tue, 23 Apr 2024 08:54:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohammad Shehar Yaar Tausif <sheharyaar48@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema

On 22/04/2024 14:21, Mohammad Shehar Yaar Tausif wrote:
> Convert USB UHCI bindings to DT schema. Documenting aspeed compatibles
> and missing properties. Adding aspeed/generic-uhci example and fix previous
> incorrect example.
> 
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@...il.com>

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: generic-uhci
> +    then:
> +      $ref: usb-hcd.yaml

Nothing improved here.

> +      required:
> +        - clocks

And this was not tested.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    uhci@...07b00 {
> +        compatible = "platform-uhci";

What happened here? This is deprecated!

> +        reg = <0xd8007b00 0x200>;
> +        interrupts = <43>;


Best regards,
Krzysztof