linux-kernel - Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 23 Apr 2024 10:11:03 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Roberto Sassu <roberto.sassu@...weicloud.com>
Cc: Johannes Berg <johannes@...solutions.net>, 
	anton ivanov <anton.ivanov@...bridgegreys.com>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-um <linux-um@...ts.infradead.org>, 
	Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH] um: Add winch to winch_handlers before registering
 winch IRQ

----- Ursprüngliche Mail -----
> Von: "Roberto Sassu" <roberto.sassu@...weicloud.com>
> An: "Johannes Berg" <johannes@...solutions.net>, "richard" <richard@....at>, "anton ivanov"
> <anton.ivanov@...bridgegreys.com>
> CC: "linux-kernel" <linux-kernel@...r.kernel.org>, "linux-um" <linux-um@...ts.infradead.org>, "Roberto Sassu"
> <roberto.sassu@...wei.com>
> Gesendet: Dienstag, 23. April 2024 09:22:31
> Betreff: Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ

> On Thu, 2024-03-28 at 09:25 +0100, Johannes Berg wrote:
>> On Thu, 2024-03-07 at 11:49 +0100, Roberto Sassu wrote:
>> > From: Roberto Sassu <roberto.sassu@...wei.com>
>> > 
>> > Registering a winch IRQ is racy, an interrupt may occur before the winch is
>> > added to the winch_handlers list.
>> > 
>> > If that happens, register_winch_irq() adds to that list a winch that is
>> > scheduled to be (or has already been) freed, causing a panic later in
>> > winch_cleanup().
>> > 
>> > Avoid the race by adding the winch to the winch_handlers list before
>> > registering the IRQ, and rolling back if um_request_irq() fails.
>> > 
>> 
>> Reviewed-by: Johannes Berg <johannes@...solutions.net>
> 
> Thank you! Richard, are you going to pick this up?

Yes, it's already in my local queue.

Thanks,
//richard