linux-kernel - Re: [PATCH net-next] net: hns3: flower: validate control flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiehF8MaL7XYLk2X@nanopsycho>
Date: Tue, 23 Apr 2024 13:52:55 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yisen Zhuang <yisen.zhuang@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>,
	Jijie Shao <shaojijie@...wei.com>
Subject: Re: [PATCH net-next] net: hns3: flower: validate control flags

Mon, Apr 22, 2024 at 05:27:16PM CEST, ast@...erby.net wrote:
>This driver currently doesn't support any control flags.
>
>Use flow_rule_has_control_flags() to check for control flags,
>such as can be set through `tc flower ... ip_flags frag`.
>
>In case any control flags are masked, flow_rule_has_control_flags()
>sets a NL extended error message, and we return -EOPNOTSUPP.
>
>Also propagate extack to hclge_get_cls_key_ip(), and convert it to
>return error code.
>
>Only compile-tested.
>
>Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>

Reviewed-by: Jiri Pirko <jiri@...dia.com>