linux-kernel - Re: [PATCH v1] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 13:30:06 +0530
From: Viken Dadhaniya <quic_vdadhani@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Luca Weiss
	<luca.weiss@...rphone.com>,
        <cros-qcom-dts-watchers@...omium.org>, <andersson@...nel.org>,
        <swboyd@...omium.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rajpat@...eaurora.org>, <mka@...omium.org>, <rojay@...eaurora.org>
CC: <quic_msavaliy@...cinc.com>, <quic_anupkulk@...cinc.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration



On 4/16/2024 8:09 PM, Konrad Dybcio wrote:
> 
> 
> On 4/16/24 13:38, Luca Weiss wrote:
>> On Tue Apr 16, 2024 at 12:56 PM CEST, Viken Dadhaniya wrote:
>>> Remove CTS and RTS pinctrl configuration for UART5 node as
>>> it's designed for debug UART for all the board variants of the
>>> sc7280 chipset.
>>>
>>> Also change compatible string to debug UART.
>>
>> This change has little to do with the SoC design though and is dependent
>> on the usage on a given board, right? Also the QCM6490 datasheet
>> mentions gpio21 & gpio22 can be used for UART_CTS and UART_RFR.
> 
> Yeah, using it as a debug uart doesn't rule out flow control I don't think
> 
>>
>> But at least consistency-wise this change makes sense, in practically
>> all other SoCs one UART is marked as geni-debug-uart.
>>
>> But with this patch you should then also remove some overrides that are
>> placed in various boards already?
>>
>> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:     compatible = 
>> "qcom,geni-debug-uart";
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts:       compatible = 
>> "qcom,geni-debug-uart";
>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts:   compatible = 
>> "qcom,geni-debug-uart";
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:       compatible = 
>> "qcom,geni-debug-uart";
>> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:     compatible = 
>> "qcom,geni-debug-uart";
> 
> Definitely

Updated in V2.

> 
> Konrad