linux-kernel - Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240424075238.g7dwzjt7nqajcdgk@joelS2.panther.com>
Date: Wed, 24 Apr 2024 09:52:38 +0200
From: Joel Granados <j.granados@...sung.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
CC: Luis Chamberlain <mcgrof@...nel.org>, <josh@...htriplett.org>, Kees Cook
	<keescook@...omium.org>, Eric Biederman <ebiederm@...ssion.com>, Iurii
	Zaikin <yzaikin@...gle.com>, Steven Rostedt <rostedt@...dmis.org>, Masami
	Hiramatsu <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Thomas
	Gleixner <tglx@...utronix.de>, John Stultz <jstultz@...gle.com>, Stephen
	Boyd <sboyd@...nel.org>, Andy Lutomirski <luto@...capital.net>, Will Drewry
	<wad@...omium.org>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra
	<peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
	<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Daniel
	Bristot de Oliveira <bristot@...hat.com>, Valentin Schneider
	<vschneid@...hat.com>, Petr Mladek <pmladek@...e.com>, John Ogness
	<john.ogness@...utronix.de>, Sergey Senozhatsky <senozhatsky@...omium.org>,
	"Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>, Anil S Keshavamurthy
	<anil.s.keshavamurthy@...el.com>, "David S. Miller" <davem@...emloft.net>,
	Balbir Singh <bsingharora@...il.com>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, John Fastabend
	<john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, Martin
	KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song
	<yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev
	<sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	<linux-kernel@...r.kernel.org>, <kexec@...ts.infradead.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
	<bpf@...r.kernel.org>, <tools@...nel.org>
Subject: Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel
 dir

On Mon, Apr 22, 2024 at 04:27:47PM +0200, Konrad Dybcio wrote:
> 
> 
> On 3/28/24 16:44, Joel Granados wrote:
> > What?
> > These commits remove the sentinel element (last empty element) from the
> > sysctl arrays of all the files under the "kernel/" directory that use a
> > sysctl array for registration. The merging of the preparation patches
> > [1] to mainline allows us to remove sentinel elements without changing
> > behavior. This is safe because the sysctl registration code
> > (register_sysctl() and friends) use the array size in addition to
> > checking for a sentinel [2].
> 
> Hi,
> 
> looks like *this* "patch" made it to the sysctl tree [1], breaking b4
> for everyone else (as there's a "--- b4-submit-tracking ---" magic in
> the tree history now) on next-20240422
> 
> Please drop it (again, I'm only talking about this empty cover letter).
Here do you mean revert? or do you mean force-push without the cover
letter commit?

I did the later, but if the former is necessary I can always go back to
the old HEAD, add a revert commit and then push that.

Best

> 
> Konrad
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/commit/?h=sysctl-next&id=ec04a7fa09ddedc1d6c8b86ae281897256c7fdf0

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)