linux-kernel - Re: [PATCH 0/9] staging: media: av7110: These patches address various code style and formatting issues in the av7110 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47a8ba71-9d51-40e5-85fb-7b64a40921db@xs4all.nl>
Date: Wed, 24 Apr 2024 11:34:07 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Jonathan Bergh <bergh.jonathan@...il.com>, mchehab@...nel.org
Cc: mcgrof@...nel.org, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] staging: media: av7110: These patches address various
 code style and formatting issues in the av7110 driver

Hi Jonathan,

On 03/03/2024 20:20, Jonathan Bergh wrote:
> The following patches fix a number of code style issues identified by
> checkpatch in the av7110 driver.
> 
> Jonathan Bergh (9):
>   staging: media: av7110: Fix formatting problem where trailing statements
>     should be on a new line
>   staging: media: av7110: Remove braces for single line statement blocks
>   staging: media: av7110: Remove spaces between function name and
>     opening parenthesis
>   staging: media: av7110: Fix formatting of pointers to meet coding
>     style guidelines
>   staging: media: av7110: Fix block comments to meet code style
>     guidelines
>   staging: media: av7110: Remove extra whitespace before opening '['s
>   staging: media: av7110: Remove extra whitespace before ','
>   staging: media: av7110: Ensure whitespace ahead of opening brace '{'
>   staging: media: av7110: Ensure newline after variable declarations
> 
>  drivers/staging/media/av7110/sp8870.c | 136 +++++++++++++-------------
>  1 file changed, 70 insertions(+), 66 deletions(-)
> 

I'm sorry, but I will reject this series. This is an old driver that is
not under active development.

It is not worth the review effort I have to put into reviewing these
cleanup patches.

As the TODO file says:

- Cleanup patches for the drivers here won't be accepted.

I mentioned that before, so I'm not sure why you post another version
of cleanup patches.

Regards,

	Hans