linux-kernel - Re: [PATCH v3 2/5] rust: rbtree: add `RBTreeIterator`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Apr 2024 21:56:54 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Matt Gilbride <mattgilbride@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, Joel Fernandes <joel@...lfernandes.org>, Carlos Llamas <cmllamas@...gle.com>, Suren Baghdasaryan <surenb@...gle.com>, Christian Brauner <brauner@...nel.org>
Cc: Rob Landley <rob@...dley.net>, Davidlohr Bueso <dave@...olabs.net>, Michel Lespinasse <michel@...pinasse.org>, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] rust: rbtree: add `RBTreeIterator`

On 25.04.24 23:45, Benno Lossin wrote:
> On 18.04.24 16:15, Matt Gilbride wrote:
>> @@ -373,6 +416,56 @@ fn drop(&mut self) {
>>       }
>>   }
>>
>> +impl<'a, K, V> IntoIterator for &'a RBTree<K, V> {
>> +    type Item = (&'a K, &'a V);
>> +    type IntoIter = RBTreeIterator<'a, K, V>;
>> +
>> +    fn into_iter(self) -> Self::IntoIter {
>> +        self.iter()
>> +    }
>> +}
>> +
>> +/// An iterator over the nodes of a [`RBTree`].
>> +///
>> +/// Instances are created by calling [`RBTree::iter`].
>> +///
>> +/// # Invariants
>> +/// - `self.next` is a valid pointer.
>> +/// - `self.next` points to a node stored inside of a valid `RBTree`.
>> +pub struct RBTreeIterator<'a, K, V> {
>> +    _tree: PhantomData<&'a RBTree<K, V>>,
>> +    next: *mut bindings::rb_node,
>> +}
>> +
>> +// SAFETY: The [`RBTreeIterator`] gives out immutable references to K and V, so it has the same
>> +// thread safety requirements as immutable references.
>> +unsafe impl<'a, K: Sync, V: Sync> Send for RBTreeIterator<'a, K, V> {}
> 
> The bounds on `K` and `V` look like typos to me. They should be `Send`
> instead.

Oops, scratch this comment, what you wrote is correct, since we treat
`RBTreeIterator` as `(&K, &V)`.

-- 
Cheers,
Benno