linux-kernel - Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mspigex0.fsf@kernel.org>
Date: Thu, 25 Apr 2024 09:00:27 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Breno Leitao <leitao@...ian.org>,  "leit@...a.com" <leit@...a.com>,
  "open list:REALTEK WIRELESS DRIVER (rtw89)"
 <linux-wireless@...r.kernel.org>,  open list
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device

Kalle Valo <kvalo@...nel.org> writes:

> Ping-Ke Shih <pkshih@...ltek.com> writes:
>
>> Breno Leitao <leitao@...ian.org> wrote:
>>> Embedding net_device into structures prohibits the usage of flexible
>>> arrays in the net_device structure. For more details, see the discussion
>>> at [1].
>>> 
>>> Un-embed the net_device from the private struct by converting it
>>> into a pointer. Then use the leverage the new alloc_netdev_dummy()
>>> helper to allocate and initialize dummy devices.
>>> 
>>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>>> 
>>> Signed-off-by: Breno Leitao <leitao@...ian.org>
>>
>> I think this patch should go via net-next tree, because wireless-next tree
>> doesn't have patch of dummy devices yet.
>>
>> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
>
> FWIW I sent the wireless-next pull request yesterday and once it pulled
> we will fast forward wireless-next to latest net-next.

Oh, I just realised that this is not CCed to netdev so their patchwork
won't even see the patch. Ping, I recommend that you wait for the
dependency commits to trickle down to your tree and then apply the
patch. That's the simplest approach and no need to resend anything.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches