linux-kernel - Re: [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZioGq1/zlRP1o7dj@engicam>
Date: Thu, 25 Apr 2024 09:30:51 +0200
From: Fabio Aiuto <fabio.aiuto@...icam.com>
To: Shawn Guo <shawnguo2@...h.net>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Matteo Lisi <matteo.lisi@...icam.com>,
	Mirko Ardinghi <mirko.ardinghi@...icam.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: imx93: add Engicam i.Core MX93 SoM

Dear Shawn,

Il Thu, Apr 25, 2024 at 03:25:28PM +0800, Shawn Guo ha scritto:
> On Fri, Apr 19, 2024 at 04:49:52PM +0200, Fabio Aiuto wrote:
<snip>
> > +			MX93_PAD_SD2_DATA3__USDHC2_DATA3        0x130e
> > +			MX93_PAD_SD2_VSELECT__USDHC2_VSELECT	0x51e
> 
> Could you try to align the indents, so that those hex values appear at
> the same column?

thanks for your review, I will send a v5.

kr,

fabio

> 
> Shawn
> 
> > +		>;
> > +	};
> > +
> > +	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> > +		fsl,pins = <
> > +			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e
> > +		>;
> > +	};
> > +};
> > -- 
> > 2.34.1
> > 
>