linux-kernel - Re: [PATCH 1/3] dt-bindings: regulator: st,stm32mp1-pwr-reg: add correct compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ce28eee-263c-4a06-85b5-5b382cbed35a@foss.st.com>
Date: Thu, 25 Apr 2024 15:55:59 +0200
From: Patrick DELAUNAY <patrick.delaunay@...s.st.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Alexandre TORGUE
	<alexandre.torgue@...s.st.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime
 Coquelin <mcoquelin.stm32@...il.com>,
        Pascal Paillet <p.paillet@...s.st.com>
CC: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 1/3] dt-bindings: regulator: st,stm32mp1-pwr-reg: add
 correct compatible

Hi,

On 4/25/24 10:52, Krzysztof Kozlowski wrote:
> On 25/04/2024 09:48, Patrick Delaunay wrote:
>> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg"
>> and define the new compatible "st,stm32mp1-pwr-reg".
>> The old compatible is only keep for compatibility with old device trees.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@...s.st.com>
>> ---
>>
>>   .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml  | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
>> index c9586d277f41..2a52f9e769c2 100644
>> --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>>   
>>   properties:
>>     compatible:
>> -    const: st,stm32mp1,pwr-reg
>> +    enum:
>> +      - st,stm32mp1-pwr-reg
>> +      - st,stm32mp1,pwr-reg
> Please make it oneOf:
>   - const: new one
>   - const: old one
>     deprecated: true

ok, I push a V2 soon.


>
> Best regards,
> Krzysztof

Regards

Patrick