linux-kernel - Re: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8023ea8c1eab725baf0389fe34b918bb5dd924c8.camel@linaro.org>
Date: Fri, 26 Apr 2024 11:54:57 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Sylwester Nawrocki
 <s.nawrocki@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>, Linus
 Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Tomasz Figa <tomasz.figa@...il.com>, Peter
 Griffin <peter.griffin@...aro.org>, semen.protsenko@...aro.org
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Will McVicker
	 <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl
 needs a clock

On Thu, 2024-04-25 at 20:18 +0200, Krzysztof Kozlowski wrote:
> On 25/04/2024 20:15, Krzysztof Kozlowski wrote:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            const: google,gs101-pinctrl
> > > +    then:
> > > +      required:
> > > +        - clocks
> > > +        - clock-names
> > 
> > else:
> >   properties:
> >     clocks: false
> >     clock-names: false
> > 
> > but anyway this is all a bit fragile, because pinctrl is not a driver
> > and you rely on initcall ordering.
> 
> It is a driver, although initcall ordering is still there. Anyway, it's
> the first soc requiring clock for pinctrl

If I see it right, E850 has similar gates, and like on gs101 they're currently
also all marked as CLK_IGNORE_UNUSED in the e850 clock driver with a comment that
a driver update is needed. I've added Sam.

Cheers,
Andre'