linux-kernel - Re: [PATCH] netfs: Fix the pre-flush when appending to a file in writethrough mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <873caf750d495a1850839f30fb120be7c6b5fd36.camel@kernel.org>
Date: Fri, 26 Apr 2024 07:43:18 -0400
From: Jeffrey Layton <jlayton@...nel.org>
To: David Howells <dhowells@...hat.com>, Christian Brauner
 <brauner@...nel.org>
Cc: Eric Van Hensbergen <ericvh@...nel.org>, Latchesar Ionkov
 <lucho@...kov.net>,  Dominique Martinet <asmadeus@...ewreck.org>, Christian
 Schoenebeck <linux_oss@...debyte.com>, Marc Dionne
 <marc.dionne@...istor.com>, netfs@...ts.linux.dev, 
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, v9fs@...ts.linux.dev, 
 linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfs: Fix the pre-flush when appending to a file in
 writethrough mode

On Fri, 2024-04-26 at 12:15 +0100, David Howells wrote:
> In netfs_perform_write(), when the file is marked NETFS_ICTX_WRITETHROUGH
> or O_*SYNC or RWF_*SYNC was specified, write-through caching is performed
> on a buffered file.  When setting up for write-through, we flush any
> conflicting writes in the region and wait for the write to complete,
> failing if there's a write error to return.
> 
> The issue arises if we're writing at or above the EOF position because we
> skip the flush and - more importantly - the wait.  This becomes a problem
> if there's a partial folio at the end of the file that is being written out
> and we want to make a write to it too.  Both the already-running write and
> the write we start both want to clear the writeback mark, but whoever is
> second causes a warning looking something like:
> 
>     ------------[ cut here ]------------
>     R=00000012: folio 11 is not under writeback
>     WARNING: CPU: 34 PID: 654 at fs/netfs/write_collect.c:105
>     ...
>     CPU: 34 PID: 654 Comm: kworker/u386:27 Tainted: G S ...
>     ...
>     Workqueue: events_unbound netfs_write_collection_worker
>     ...
>     RIP: 0010:netfs_writeback_lookup_folio
> 
> Fix this by making the flush-and-wait unconditional.  It will do nothing if
> there are no folios in the pagecache and will return quickly if there are
> no folios in the region specified.
> 
> Further, move the WBC attachment above the flush call as the flush is going
> to attach a WBC and detach it again if it is not present - and since we
> need one anyway we might as well share it.
> 
> Fixes: 41d8e7673a77 ("netfs: Implement a write-through caching option")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202404161031.468b84f-oliver.sang@intel.com
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Eric Van Hensbergen <ericvh@...nel.org>
> cc: Latchesar Ionkov <lucho@...kov.net>
> cc: Dominique Martinet <asmadeus@...ewreck.org>
> cc: Christian Schoenebeck <linux_oss@...debyte.com>
> cc: Marc Dionne <marc.dionne@...istor.com>
> cc: netfs@...ts.linux.dev
> cc: linux-fsdevel@...r.kernel.org
> cc: linux-mm@...ck.org
> cc: v9fs@...ts.linux.dev
> cc: linux-afs@...ts.infradead.org
> cc: linux-cifs@...r.kernel.org
> ---
>  fs/netfs/buffered_write.c |   13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c
> index 9a0d32e4b422..07aff231926c 100644
> --- a/fs/netfs/buffered_write.c
> +++ b/fs/netfs/buffered_write.c
> @@ -172,15 +172,14 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,
>  	if (unlikely(test_bit(NETFS_ICTX_WRITETHROUGH, &ctx->flags) ||
>  		     iocb->ki_flags & (IOCB_DSYNC | IOCB_SYNC))
>  	    ) {
> -		if (pos < i_size_read(inode)) {
> -			ret = filemap_write_and_wait_range(mapping, pos, pos + iter->count);
> -			if (ret < 0) {
> -				goto out;
> -			}
> -		}
> -
>  		wbc_attach_fdatawrite_inode(&wbc, mapping->host);
>  
> +		ret = filemap_write_and_wait_range(mapping, pos, pos + iter->count);
> +		if (ret < 0) {
> +			wbc_detach_inode(&wbc);
> +			goto out;
> +		}
> +
>  		wreq = netfs_begin_writethrough(iocb, iter->count);
>  		if (IS_ERR(wreq)) {
>  			wbc_detach_inode(&wbc);
> 

Reviewed-by: Jeffrey Layton <jlayton@...nel.org>