linux-kernel - Re: [PATCH net v2] net: wwan: Fix missing net device name for error message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi-VNEUJK+AUcyCXii5in6OLfKjxrNM1KHwQf=9QV_cqJA@mail.gmail.com>
Date: Fri, 26 Apr 2024 14:04:39 +0200
From: Loic Poulain <loic.poulain@...aro.org>
To: Slark Xiao <slark_xiao@....com>
Cc: ryazanov.s.a@...il.com, johannes@...solutions.net, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Hariprasad Kelam <hkelam@...vell.com>
Subject: Re: [PATCH net v2] net: wwan: Fix missing net device name for error
 message print

Hello,

On Fri, 26 Apr 2024 at 11:25, Slark Xiao <slark_xiao@....com> wrote:
>
> In my local, I got an error print in dmesg like below:
> "sequence number glitch prev=487 curr=0"
> After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage
> of this net_err_ratelimited() API in other files, I think we
> should add net device name print before message context.
>
> Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")

This is more a cosmetic change than a bugfix, you should target net-next IMO.
Also as said in another feedback, the commit message does not match the change,
since you're not printing the device name.