linux-kernel - Re:Re: [PATCH net v2] net: wwan: Fix missing net device name for error message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f434e77.2191.18f1e216533.Coremail.slark_xiao@163.com>
Date: Sat, 27 Apr 2024 13:57:36 +0800 (CST)
From: "Slark Xiao" <slark_xiao@....com>
To: "Loic Poulain" <loic.poulain@...aro.org>
Cc: ryazanov.s.a@...il.com, johannes@...solutions.net, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Hariprasad Kelam" <hkelam@...vell.com>
Subject: Re:Re: [PATCH net v2] net: wwan: Fix missing net device name for
 error message print


At 2024-04-26 20:04:39, "Loic Poulain" <loic.poulain@...aro.org> wrote:
>Hello,
>
>On Fri, 26 Apr 2024 at 11:25, Slark Xiao <slark_xiao@....com> wrote:
>>
>> In my local, I got an error print in dmesg like below:
>> "sequence number glitch prev=487 curr=0"
>> After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage
>> of this net_err_ratelimited() API in other files, I think we
>> should add net device name print before message context.
>>
>> Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
>
>This is more a cosmetic change than a bugfix, you should target net-next IMO.
>Also as said in another feedback, the commit message does not match the change,
>since you're not printing the device name.
Agree. But in some functions, we can't call the net device name directory from the
parameters of this function, such as mbim_rx_verify_ndp16(). There is no *mbim or
*ndev or *mhi_dev.