linux-kernel - Re: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <392a0fa9-9d7e-4cdc-b09b-68f9cf92fe23@postmarketos.org>
Date: Fri, 26 Apr 2024 16:48:53 +0300
From: Alexey Minnekhanov <alexeymin@...tmarketos.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Sibi Sankar <quic_sibis@...cinc.com>,
 Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-remoteproc@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>,
 Xilin Wu <wuxilin123@...il.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: Re: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation

On 24.04.2024 12:28, Dmitry Baryshkov wrote:
> Existing userspace protection domain mapper implementation has several
> issue. It doesn't play well with CONFIG_EXTRA_FIRMWARE, it doesn't
> reread JSON files if firmware location is changed (or if firmware was
> not available at the time pd-mapper was started but the corresponding
> directory is mounted later), etc.
> 
> Provide in-kernel service implementing protection domain mapping
> required to work with several services, which are provided by the DSP
> firmware.
> 
> This module is loaded automatically by the remoteproc drivers when
> necessary via the symbol dependency. It uses a root node to match a
> protection domains map for a particular board. It is not possible to
> implement it as a 'driver' as there is no corresponding device.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 

> diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c
..
> +
> +static const struct qcom_pdm_domain_data *sdm660_domains[] = {
> +	&adsp_audio_pd,
> +	&adsp_root_pd,
> +	&mpss_wlan_pd,
> +	NULL,
> +};
> +

On my SDM660 device (xiaomi-lavender) I see also the following files on 
modem partition:
  - adsps.jsn with sensor_pd (instance id 74)
  - cdspr.jsn with cdsp root_pd (instance id 76)
  - modemr.jsn with root_pd (instance id 180)

I see these numbers match those you already have defined above, so 
perhaps sdm660_domains should also have adsp_sensor_pd, cdsp_root_pd, 
and mpss_root_pd?

I'm not sure how useful they are currently, as AFAIK cdsp is not added 
to sdm660 DT at all; and ADSP sensors are very hard to use/test, needs 
very special userspace...

-- 
Regards,
Alexey Minnekhanov
postmarketOS developer