linux-kernel - Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 16:48:17 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: LuMingYin <lumingyindetect@....com>
cc: LKML <linux-kernel@...r.kernel.org>, 
    linux-serial <linux-serial@...r.kernel.org>, 
    Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, jirislaby@...nel.or
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

On Fri, 26 Apr 2024, lumingyindetect@....com wrote:

> From: LuMingYin <lumingyindetect@....com>
> 
> The return statements at line 347 and line 351 in the lpss8250_probe() function result in a memory leak of the variable pdev.
> Add a label named free_irq_vectors in the lpss8250_probe() function to release the memory area pointed to by pdev.
> Modify the two return statements mentioned above to jump to the label "free_irq_vectors" instead.

Also, this is not a 100m sprint. Please leave time for people to comment 
on your previous submission before sending the next version out.

People are from different timezones and have other things to look too 
besides your patch so they might not be happy if they find 4 versions of 
your patch in their inbox before even having time to look at the first 
one.

-- 
 i.