linux-kernel - Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024042652-even-mud-476d@gregkh>
Date: Fri, 26 Apr 2024 15:55:40 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: lumingyindetect@....com
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	ilpo.jarvinen@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
	jirislaby@...nel.or
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

On Fri, Apr 26, 2024 at 02:39:59PM +0100, lumingyindetect@....com wrote:
> From: LuMingYin <lumingyindetect@....com>
> 
> The return statements at line 347 and line 351 in the lpss8250_probe() function result in a memory leak of the variable pdev.
> Add a label named free_irq_vectors in the lpss8250_probe() function to release the memory area pointed to by pdev.
> Modify the two return statements mentioned above to jump to the label "free_irq_vectors" instead.
> 
> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67 ("serial: 8250_lpss: fix memory in lpss8250_probe()")
> 
> Signed-off-by: LuMingYin <lumingyindetect@....com>

Please stop and read all of the instructions provide, and then go read
the "how to submit your first patch" tutorial at kernelnewbies.org and
compare that to what you have been sending here.

You also keep sending stuff to quickly, patches should be, at the most,
sent once a day, and even then, that would be very quick.

Relax, take the weekend off, and come back next week with a proper
change based on the documentation.

thanks,

greg k-h