linux-kernel - Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC bus frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002340b7-86e2-4be3-8468-71d59233c32e@intel.com>
Date: Fri, 26 Apr 2024 22:38:49 -0700
From: "Chen, Zide" <zide.chen@...el.com>
To: Reinette Chatre <reinette.chatre@...el.com>, isaku.yamahata@...el.com,
 pbonzini@...hat.com, erdemaktas@...gle.com, vkuznets@...hat.com,
 seanjc@...gle.com, vannapurve@...gle.com, jmattson@...gle.com,
 mlevitsk@...hat.com, xiaoyao.li@...el.com, chao.gao@...el.com,
 rick.p.edgecombe@...el.com
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency



On 4/26/2024 4:26 PM, Reinette Chatre wrote:
> Hi Zide,
> 
> On 4/26/2024 4:06 PM, Chen, Zide wrote:
>>
>>
>> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> new file mode 100644
>>> index 000000000000..5100b28228af
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> @@ -0,0 +1,166 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Test configure of APIC bus frequency.
>>> + *
>>> + * Copyright (c) 2024 Intel Corporation
>>> + *
>>> + * To verify if the APIC bus frequency can be configured this test starts
>>
>> Nit: some typos here?
> 
> Apologies but this is not obvious to me. Could you please help
> by pointing out all those typos to me?

Do you think it's more readable to add a ","?

- * To verify if the APIC bus frequency can be configured this test starts
+ * To verify if the APIC bus frequency can be configured, this test starts
  * by setting the TSC frequency in KVM, and then: