linux-kernel - Re: [PATCH 4/7] iio: imu: adis_buffer: Add buffer setup API with buffer attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404271027.ySHRhuOH-lkp@intel.com>
Date: Sat, 27 Apr 2024 11:05:34 +0800
From: kernel test robot <lkp@...el.com>
To: Ramona Gradinariu <ramona.bolboaca13@...il.com>,
	linux-kernel@...r.kernel.org, jic23@...nel.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	conor+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	robh@...nel.org, nuno.sa@...log.com
Cc: oe-kbuild-all@...ts.linux.dev,
	Ramona Gradinariu <ramona.bolboaca13@...il.com>
Subject: Re: [PATCH 4/7] iio: imu: adis_buffer: Add buffer setup API with
 buffer attributes

Hi Ramona,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.9-rc5 next-20240426]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240426-215728
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20240426135339.185602-5-ramona.bolboaca13%40gmail.com
patch subject: [PATCH 4/7] iio: imu: adis_buffer: Add buffer setup API with buffer attributes
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240427/202404271027.ySHRhuOH-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240427/202404271027.ySHRhuOH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404271027.ySHRhuOH-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/imu/adis_buffer.c: In function 'devm_adis_setup_buffer_and_trigger_with_attrs':
>> drivers/iio/imu/adis_buffer.c:207:51: error: passing argument 7 of 'devm_iio_triggered_buffer_setup_ext' from incompatible pointer type [-Werror=incompatible-pointer-types]
     207 |                                                   buffer_attrs);
         |                                                   ^~~~~~~~~~~~
         |                                                   |
         |                                                   const struct attribute **
   In file included from drivers/iio/imu/adis_buffer.c:19:
   include/linux/iio/triggered_buffer.h:31:69: note: expected 'const struct iio_dev_attr **' but argument is of type 'const struct attribute **'
      31 |                                         const struct iio_dev_attr **buffer_attrs);
         |                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/devm_iio_triggered_buffer_setup_ext +207 drivers/iio/imu/adis_buffer.c

   176	
   177	/**
   178	 * devm_adis_setup_buffer_and_trigger_with_attrs() - Sets up buffer and trigger
   179	 * for the managed adis device with buffer attributes.
   180	 * @adis: The adis device
   181	 * @indio_dev: The IIO device
   182	 * @trigger_handler: Trigger handler: should handle the buffer readings.
   183	 * @ops: Optional buffer setup functions, may be NULL.
   184	 * @buffer_attrs: Extra buffer attributes.
   185	 *
   186	 * Returns 0 on success, a negative error code otherwise.
   187	 *
   188	 * This function sets up the buffer (with buffer setup functions and extra
   189	 * buffer attributes) and trigger for a adis devices with buffer attributes.
   190	 */
   191	int
   192	devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis, struct iio_dev *indio_dev,
   193						      irq_handler_t trigger_handler,
   194						      const struct iio_buffer_setup_ops *ops,
   195						      const struct attribute **buffer_attrs)
   196	{
   197		int ret;
   198	
   199		if (!trigger_handler)
   200			trigger_handler = adis_trigger_handler;
   201	
   202		ret = devm_iio_triggered_buffer_setup_ext(&adis->spi->dev, indio_dev,
   203							  &iio_pollfunc_store_time,
   204							  trigger_handler,
   205							  IIO_BUFFER_DIRECTION_IN,
   206							  ops,
 > 207							  buffer_attrs);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki