linux-kernel - Re: [PATCH 3/7] iio: imu: adis16475: Re-define ADIS16475

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240428144953.1486da0d@jic23-huawei>
Date: Sun, 28 Apr 2024 14:49:53 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@...il.com>,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, conor+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, robh@...nel.org, nuno.sa@...log.com,
 oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 3/7] iio: imu: adis16475: Re-define ADIS16475_DATA

On Sat, 27 Apr 2024 10:00:49 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Ramona,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on jic23-iio/togreg]
> [also build test WARNING on linus/master v6.9-rc5 next-20240426]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240426-215728
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/20240426135339.185602-4-ramona.bolboaca13%40gmail.com
> patch subject: [PATCH 3/7] iio: imu: adis16475: Re-define ADIS16475_DATA
> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240427/202404270958.43fSMp4J-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240427/202404270958.43fSMp4J-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404270958.43fSMp4J-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/iio/imu/adis16475.c:734:34: warning: 'adis1650x_timeouts' defined but not used [-Wunused-const-variable=]  
>      734 | static const struct adis_timeout adis1650x_timeouts = {
>          |                                  ^~~~~~~~~~~~~~~~~~
> 

I missed that entirely when reading.  Indeed, looks like a cut and paste
issue where some entries should still be using this structure and got
accidentally modified.

A case of robots saving the day :)

Jonathan
> 
> vim +/adis1650x_timeouts +734 drivers/iio/imu/adis16475.c
> 
> fff7352bf7a3ce Nuno Sá 2020-04-13  733  
> fff7352bf7a3ce Nuno Sá 2020-04-13 @734  static const struct adis_timeout adis1650x_timeouts = {
> fff7352bf7a3ce Nuno Sá 2020-04-13  735  	.reset_ms = 260,
> fff7352bf7a3ce Nuno Sá 2020-04-13  736  	.sw_reset_ms = 260,
> fff7352bf7a3ce Nuno Sá 2020-04-13  737  	.self_test_ms = 30,
> fff7352bf7a3ce Nuno Sá 2020-04-13  738  };
> fff7352bf7a3ce Nuno Sá 2020-04-13  739  
>