linux-kernel - Re: [PATCH] Bluetooth: qca: generalise device address check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZJyqrNKebwPPPqjOAdrkpBJ0fqHyD2iVtypeQKCDcL+AQ@mail.gmail.com>
Date: Mon, 29 Apr 2024 13:12:40 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Johan Hovold <johan@...nel.org>
Cc: Janaki Ramaiah Thota <quic_janathot@...cinc.com>, Doug Anderson <dianders@...omium.org>, 
	Johan Hovold <johan+linaro@...nel.org>, Marcel Holtmann <marcel@...tmann.org>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, quic_mohamull@...cinc.com, quic_hbandi@...cinc.com, 
	quic_anubhavg@...cinc.com
Subject: Re: [PATCH] Bluetooth: qca: generalise device address check

Hi,

On Mon, Apr 29, 2024 at 10:02 AM Johan Hovold <johan@...nel.org> wrote:
>
> Hi Janaki,
>
> Please avoid top and remember to trim unnecessary context when replying
> to the mailing lists.
>
> On Mon, Apr 29, 2024 at 03:34:32PM +0530, Janaki Ramaiah Thota wrote:
>
> > Having a default BDA list from NVM BDA tag value will prevent developers
> > from using the device if there is no user space app(In Fluoride) to set
> > the BDA. Therefore, we are requesting to use default address check patch,
> > so that developer can change the NVM BDA to make use of the device.
>
> But a developer on such an old platform that can patch and replace the
> NVM configuration file should also be able to just disable the check in
> the driver right (e.g. by commenting out the call to
> qca_check_bdaddr())?
>
> >   List Of default Addresses:
> >   ---------------------------------------------------------
> > |       BDA          |      Chipset                       |
> >   ---------------------------------------------------------
> > | 39 80 10 00 00 20  |  WCN3988 with ROM Version 0x0200   |
> >   ---------------------------------------------------------
> > | 39 80 12 74 08 00  |  WCN3988 with ROM Version 0x0201   |
> >   ---------------------------------------------------------
> > | 39 90 21 64 07 00  |  WCN3990                           |
> >   ---------------------------------------------------------
> > | 39 98 00 00 5A AD  |  WCN3991                           |
> >   ---------------------------------------------------------
> > | 00 00 00 00 5A AD  |  QCA DEFAULT                       |
> >   ---------------------------------------------------------
>
> What about WCN6750 and 64:90:00:00:5a:ad?
>
> And then there's currently also:
>
> > > bluetooth hci0: bd_addr = 61:47:aa:31:22:14 (qca/nvm_00130300.bin)
> > > bluetooth hci0: bd_addr = 61:47:aa:32:44:07 (qca/nvm_00130302.bin)
>
> Which controllers use these configurations?

These are not unique addresses though, we can't just have addresses by
chipset address mapping logic as that would cause address clashes over
the air, e.g. if there are other devices with the same chipset in the
vicinity.

-- 
Luiz Augusto von Dentz