linux-kernel - Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qwusw4lmmv7iff64l3qcdnnw762xlwag745dw5vhtfxspvsw2r@73ocsqlyhp5e>
Date: Mon, 29 Apr 2024 09:18:49 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, 
	Yangtao Li <frank.li@...o.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback
 returning void

Hello Daniel,

On Tue, Apr 23, 2024 at 09:22:23AM +0200, Daniel Lezcano wrote:
> On 09/04/2024 18:32, Uwe Kleine-König wrote:
> > On Wed, Mar 06, 2024 at 10:33:06PM +0100, Uwe Kleine-König wrote:
> > > On Mon, Dec 04, 2023 at 12:55:17PM +0100, Uwe Kleine-König wrote:
> > > > On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> > > > > The .remove() callback for a platform driver returns an int which makes
> > > > > many driver authors wrongly assume it's possible to do error handling by
> > > > > returning an error code. However the value returned is (mostly) ignored
> > > > > and this typically results in resource leaks. To improve here there is a
> > > > > quest to make the remove callback return void. In the first step of this
> > > > > quest all drivers are converted to .remove_new() which already returns
> > > > > void.
> > > > > 
> > > > > Trivially convert this driver from always returning zero in the remove
> > > > > callback to the void returning variant.
> > > > > 
> > > > > Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > > > Signed-off-by: Yangtao Li <frank.li@...o.com>
> > > > 
> > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > > 
> > > > Can you pick this up?
> > > 
> > > This patch isn't in next yet. Is this still on someone's radar for
> > > application? Would be great if this patch made it into the mainline
> > > during the upcomming merge window.
> > 
> > It didn't made it into the merge window leading to 6.9-rc1. What are
> > the chances to get it into v6.10-rc1?
> > 
> > I just checked, the patch was submitted when Linus's tree was just after
> > v6.5-rc1. So it already missed four merge windows without any maintainer
> > feedback :-\
> 
> Sorry, it is applied now.

Is it expected that this patch didn't appear in next yet now that you
applied it?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)