linux-kernel - Re: drm/debugfs: Drop conditionals around of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 13:30:24 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Sui Jingfeng <suijingfeng@...c.ac.cn>
Cc: Sui Jingfeng <sui.jingfeng@...ux.dev>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	Douglas Anderson <dianders@...omium.org>, Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
	Biju Das <biju.das.jz@...renesas.com>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: drm/debugfs: Drop conditionals around of_node pointers

On Sun, Apr 28, 2024 at 04:52:13PM +0800, Sui Jingfeng wrote:
> ping
> 
> 在 2024/3/22 06:22, Sui Jingfeng 写道:
> > Having conditional around the of_node pointer of the drm_bridge structure
> > turns out to make driver code use ugly #ifdef blocks.

The code being ugly is an opinion, what problem is it causing exactly?

> Drop the conditionals to simplify debugfs.

What does it simplifies?

> > 
> > Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> > Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>

Why do we want to backport that patch to stable?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)