linux-kernel - Re: Re: drm/debugfs: Drop conditionals around of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6db82a3f.c7.18f2c927d9f.Coremail.suijingfeng@bosc.ac.cn>
Date: Tue, 30 Apr 2024 09:15:49 +0800 (GMT+08:00)
From: 隋景峰 <suijingfeng@...c.ac.cn>
To: "Maxime Ripard" <mripard@...nel.org>
Cc: "Sui Jingfeng" <sui.jingfeng@...ux.dev>, 
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, 
	"Thomas Zimmermann" <tzimmermann@...e.de>, 
	"David Airlie" <airlied@...il.com>, 
	"Daniel Vetter" <daniel@...ll.ch>, 
	"Douglas Anderson" <dianders@...omium.org>, 
	"Biju Das" <biju.das.jz@...renesas.com>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: Re: drm/debugfs: Drop conditionals around of_node pointers

Hi,


> -----原始邮件-----
> 发件人: "Maxime Ripard" <mripard@...nel.org>
> 发送时间: 2024-04-29 19:30:24 (星期一)
> 收件人: "Sui Jingfeng" <suijingfeng@...c.ac.cn>
> 抄送: "Sui Jingfeng" <sui.jingfeng@...ux.dev>, "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie" <airlied@...il.com>, "Daniel Vetter" <daniel@...ll.ch>, "Douglas Anderson" <dianders@...omium.org>, "Laurent Pinchart" <laurent.pinchart+renesas@...asonboard.com>, "Biju Das" <biju.das.jz@...renesas.com>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
> 主题: Re: drm/debugfs: Drop conditionals around of_node pointers
> 
> On Sun, Apr 28, 2024 at 04:52:13PM +0800, Sui Jingfeng wrote:
> > ping
> > 
> > 在 2024/3/22 06:22, Sui Jingfeng 写道:
> > > Having conditional around the of_node pointer of the drm_bridge structure
> > > turns out to make driver code use ugly #ifdef blocks.
> 
> The code being ugly is an opinion, what problem is it causing exactly?
> 
> > Drop the conditionals to simplify debugfs.
> 
> What does it simplifies?
> 
> > > 
> > > Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> > > Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>
> 
> Why do we want to backport that patch to stable?

My commit message is written based on commit of d8dfccde2709

$ git show c9e358dfc4a8
    
    This patch is based on commit c9e358dfc4a8 ("driver-core: remove
    conditionals around devicetree pointers").
    
    Having conditional around the of_node pointer of the drm_bridge
    structure turns out to make driver code use ugly #ifdef blocks. Drop the
    conditionals to simplify drivers. While this slightly increases the size
    of struct drm_bridge on non-OF system, the number of bridges used today
    and foreseen tomorrow on those systems is very low, so this shouldn't be
    an issue.
    
    So drop #if conditionals by adding struct device_node forward declaration.

> Maxime

I'm just start to contribute by mimic other people's tone, there seems no need
to over read.